Fix TrackioCallback fails to log evaluation metrics after training ends#46935
Open
lewtun wants to merge 3 commits into
Open
Fix TrackioCallback fails to log evaluation metrics after training ends#46935lewtun wants to merge 3 commits into
TrackioCallback fails to log evaluation metrics after training ends#46935lewtun wants to merge 3 commits into
Conversation
TrackioCallback fails to log evaluation metrics after training ends
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
lewtun
commented
Jun 27, 2026
| is_torch_available, | ||
| ) | ||
| from transformers.integrations.integration_utils import KubeflowCallback, SwanLabCallback | ||
| from transformers.integrations.integration_utils import KubeflowCallback, SwanLabCallback, TrackioCallback |
Member
Author
There was a problem hiding this comment.
I added a regression test since we didn't have any at all for trackio. Happy to remove it if that's preferred
Member
Author
|
The failing tests seem unrelated to my changes |
Contributor
|
CI Dashboard: View test results in Grafana |
qgallouedec
approved these changes
Jun 27, 2026
qgallouedec
left a comment
Member
There was a problem hiding this comment.
Didn't try myself but the justification and fix lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the following issue:
TrackioCallback.on_train_end()callstrackio.finish(), which clears Trackio’s active run. However, the callback keeps_initialized=True. If user code callstrainer.evaluate()ortrainer.predict()aftertrainer.train(), the callback later receiveson_log()/on_predict(). Because_initializedis still True, it skipssetup()and callstrackio.log()without an active Trackio run, raising:The fix is to reset
TrackioCallback._initializedaftertrackio.finish()inon_train_end(). Then subsequent logging re-runssetup()and reinitializes/resumes the Trackio run before logging metrics.I've also added a regression test which triggers the problem on
mainand verified the fix resolves it.Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request checks?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.