[serge] Fix 12 integration tests for model glm46v failing with other (other (12))#46927
Open
sergereview[bot] wants to merge 1 commit into
Open
[serge] Fix 12 integration tests for model glm46v failing with other (other (12))#46927sergereview[bot] wants to merge 1 commit into
glm46v failing with other (other (12))#46927sergereview[bot] wants to merge 1 commit into
Conversation
…er` (other (12))
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: glm46v |
Contributor
|
CI Dashboard: View test results in Grafana |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original CI failure
1/1: 12 integration tests for modelglm46vfailing withother(other (12))tests/models/glm46v/test_modeling_glm46v.py::Glm46VIntegrationTest::test_small_model_integration_test[multi-gpu] (other, seen 7/7)Relates to #46906
The
glm46vintegration tests fail withRuntimeError: Expected tensor for argument #1 'indices' to have one of the following scalar types: Long, Int; but got CUDABFloat16Type insteadwhile checking arguments fornn.Embedding.Root cause:
input_idsreach the text embedding lookup as floating-point tensors (bfloat16/float16) instead of integer indices.Glm46VModelinherits its forward fromGlm4vModel/Qwen2VLModel, and the glm46v-specific subclass does not guard the embedding input dtype.Fix: override
Glm46VModel.forwardto castinput_idstotorch.longbefore delegating to the parent forward, ensuring the embedding layer receives valid index tensors.This is the minimal library-code change; no expected output values need updating.
This change was produced automatically by serge from a CI failure report. The patch was generated by an LLM and applied by serge; review before merging.
serge
v0.1.0· model:moonshotai/Kimi-K2.7-Code· 26 LLM turns · 30 tool calls · 192.2s · 581100 in / 15584 out tokens