Fix RagTokenizer attribute delegation#46919
Open
Pruthvi226 wants to merge 1 commit into
Open
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: rag |
Contributor
|
CI Dashboard: View test results in Grafana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #35532.
This PR updates
RagTokenizerso that missing tokenizer attributes and methods are delegated to the activecurrent_tokenizer.Previously,
RagTokenizer.__call__,decode, andbatch_decodewere forwarded, but other tokenizer APIs such asencode,patch_token, andpatch_token_idwere not available through the wrapper. This causedAttributeErroreven though the active underlying tokenizer supported those attributes.The change adds a guarded
__getattr__implementation that looks up missing attributes oncurrent_tokenizer. This keeps the existing input/target tokenizer switching behavior while makingRagTokenizerbehave more like the tokenizer it wraps.A regression test was added to check:
RagTokenizer.encode(...)delegates to the question encoder in input modepatch_tokenandpatch_token_idare accessible through the wrapperhasattrencode(...)delegates to the generator after switching to target modeCode Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by code agents. We are currently bottlenecked by our ability to review and respond to them. As a result, we ask that new users do not submit pure code agent PRs at this time. You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result, this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.I used an AI coding assistant while drafting this change. I reviewed the issue, source changes, tests, and final diff before submitting.
Before submitting
Issue: #35532
No documentation update needed; this is a small tokenizer wrapper behavior fix.
Added
RagTokenizerTest::test_delegates_missing_attributes_to_current_tokenizer.Tests