fix(deepspeed): chunk ZeRO-3 missing-key param gather to avoid OOM#46918
Open
itxsamad1 wants to merge 1 commit into
Open
fix(deepspeed): chunk ZeRO-3 missing-key param gather to avoid OOM#46918itxsamad1 wants to merge 1 commit into
itxsamad1 wants to merge 1 commit into
Conversation
When initializing missing weights under DeepSpeed ZeRO-3, gathering all uninitialized parameters in a single GatheredParameters context can OOM on large sparse MoE models. Gather parameters in bounded chunks instead so peak rank-0 memory stays bounded by the chunk size. Fixes huggingface#46822
Contributor
|
CI Dashboard: View test results in Grafana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from_pretrainedunder DeepSpeed ZeRO-3 when many missing parameters need initialization (e.g. large sparse MoE models like MiniMax-M3).GatheredParameterscontext, gather them in bounded chunks so peak rank-0 memory stays bounded.Context
When loading large sparse MoE models under ZeRO-3,
_initialize_missing_keyscoalesced every uninitialized parameter into a singleGatheredParametersall-gather. For models with packed expert weights this can re-materialize hundreds of GB on rank 0 and OOM.Test plan
test_init_zero3_missing_paramsstill validates missing-key initialization under ZeRO-3Fixes #46822