Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 30s timestamp resets in Whisper long-form transcription #36612

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FaresBadrCA
Copy link

What does this PR do?

Fixes #34210 and #31942.
This is an alternative to PR #35750

It resolves the issue of timestamps rolling over every 30 seconds in the Whisper model's long-form transcription. It does this by forcing return_segments to be True when return_timestamps is True.

Before submitting

Who can review?

@eustlb, @Rocketknight1, @gante, @ylacombe

Copy link

github-actions bot commented Mar 7, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@github-actions github-actions bot marked this pull request as draft March 7, 2025 19:02
@FaresBadrCA FaresBadrCA marked this pull request as ready for review March 7, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing timestamp offset using Whisper with pipeline and sequential decoding
1 participant