Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated marian.md to Korean #34698

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

maximizemaxwell
Copy link
Contributor

What does this PR do?

Translated the marian.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

@junejae, @Jwaminju, @010kim, @4N3MONE, @boyunJang

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@stevhliu May you please review this PR?

@maximizemaxwell maximizemaxwell changed the title 🌐 [i18n-KO] Translated marian.md to Korea 🌐 [i18n-KO] Translated marian.md to Korean Nov 12, 2024
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you! We can merge once a PseudoLab team member has reviewed :)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@4N3MONE
Copy link
Contributor

4N3MONE commented Nov 12, 2024

LGTM! 번역 고생하셨습니다. 😊

@stevhliu stevhliu merged commit be8748a into huggingface:main Nov 13, 2024
9 checks passed
CezaPasc pushed a commit to CezaPasc/transformers that referenced this pull request Nov 13, 2024
* initial translation

* removed english

* Fixed Trivial Typos, updated _toctree.yml
@maximizemaxwell maximizemaxwell deleted the translate-ko_marian.md branch November 13, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants