Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated bert.md to Korean #34627

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

maximizemaxwell
Copy link
Contributor

What does this PR do?

Translated the bert.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

@junejae, @Jwaminju, @010kim, @4N3MONE, @boyunJang

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@stevhliu May you please review this PR?

@maximizemaxwell maximizemaxwell changed the title 🌐 [i18n-KO] Translated bertl.md to Korean 🌐 [i18n-KO] Translated bert.md to Korean Nov 6, 2024
maximizemaxwell and others added 2 commits November 7, 2024 08:22
Co-authored-by: YONGSANG <[email protected]>
Co-authored-by: YONGSANG <[email protected]>
@4N3MONE
Copy link
Contributor

4N3MONE commented Nov 6, 2024

사소한 수정사항 제안 남겨두었습니다.

번역 고생하셨습니다 😊

@maximizemaxwell
Copy link
Contributor Author

Thanks for suggestions!!
Those are updated now.
Any other things to change?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few more things :)

docs/source/ko/model_doc/bert.md Outdated Show resolved Hide resolved
docs/source/ko/model_doc/bert.md Outdated Show resolved Hide resolved
maximizemaxwell and others added 2 commits November 8, 2024 08:16
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
@stevhliu stevhliu merged commit a06a0d1 into huggingface:main Nov 8, 2024
9 checks passed
@maximizemaxwell maximizemaxwell deleted the translate-ko_bert.md branch November 8, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants