Uniformize kwargs for Udop processor and update docs #33628
+110
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
molbap
approved these changes
Sep 20, 2024
| @@ -106,66 +142,44 @@ def __call__( | |||
| if return_overflowing_tokens is True and return_offsets_mapping is False: | |||
There was a problem hiding this comment.
not, both args are boolean and cannot be None, right? could then be
Suggested change
| if return_overflowing_tokens is True and return_offsets_mapping is False: | |
| if return_overflowing_tokens and not return_offsets_mapping: |
Comment on lines
+126
to
+130
| boxes = output_kwargs["text_kwargs"].pop("boxes", None) | ||
| word_labels = output_kwargs["text_kwargs"].pop("word_labels", None) | ||
| text_pair = output_kwargs["text_kwargs"].pop("text_pair", None) | ||
| return_overflowing_tokens = output_kwargs["text_kwargs"].get("return_overflowing_tokens", False) | ||
| return_offsets_mapping = output_kwargs["text_kwargs"].get("return_offsets_mapping", False) |
There was a problem hiding this comment.
ugh, lots of additional args here - but no way around it I suppose. Maybe we could group a bit by default values using iterators, for style and loc, but minor nit
There was a problem hiding this comment.
Yes it's not very nice... But grouping by default values and doing list comps is a bit hard to read here I feel like
40 tasks
amyeroberts
approved these changes
Sep 21, 2024
| verbose: bool = True, | ||
| return_tensors: Optional[Union[str, TensorType]] = None, | ||
| ) -> BatchEncoding: | ||
| # The following is to capture `text_pair` argument that may be passed as a positional argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds uniformized processors kwargs following #31911 for Udop.
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@molbap @amyeroberts