Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Llava conversion for LlavaQwen2ForCausalLM with Clip vision tower #33613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Isotr0py
Copy link
Contributor

What does this PR do?

Fixes # (issue)

  • Some finetuned llava models like FreedomIntelligence/HuatuoGPT-Vision-7B also use LlavaQwen2ForCausalLM architecture, but they use Clip instead of Siglip as vision_tower.
  • However, the current llava conversion script hardcoded Qwen with Siglip, which caused the converted model with wrong vision tower config
  • This PR adapts this part to make the script more flexible.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@amyeroberts @zucchini-nlp
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Isotr0py, could you show the running, output and sucessful conversion of a previous Qwen checkpoint with these changes?

Otherwise it looks OK to me, but @zucchini-nlp will know which checkpoints we should verify are still compatible with these updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants