Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 [i18n-KO] Translated model_doc/time_series_transformer.md to Korean #33596

Merged
merged 7 commits into from
Oct 9, 2024
Merged

🌐 [i18n-KO] Translated model_doc/time_series_transformer.md to Korean #33596

merged 7 commits into from
Oct 9, 2024

Conversation

fabxoe
Copy link
Contributor

@fabxoe fabxoe commented Sep 19, 2024 •
edited
Loading

What does this PR do?

Translated the model_doc/time_series_transformer.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

@chhaewxn, @ahnjj, @jun048098, @fabxoe, @nuatmochoi, @heuristicwave

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@stevhliu May you please review this PR?

ahnjj
ahnjj suggested changes Sep 30, 2024
View reviewed changes
docs/source/ko/model_doc/time_series_transformer.md Outdated Show resolved Hide resolved
docs/source/ko/model_doc/time_series_transformer.md Outdated Show resolved Hide resolved
docs/source/ko/model_doc/time_series_transformer.md Outdated Show resolved Hide resolved
docs/source/ko/model_doc/time_series_transformer.md Outdated Show resolved Hide resolved
docs/source/ko/model_doc/time_series_transformer.md

## Resources[[resources]]

시작하는 데 도움이 되는 Hugging Face와 community 자료 목록(🌎로 표시됨) 입니다. 여기에 포함될 자료를 제출하고 싶으시다면 PR(Pull Request)를 열어주세요. 리뷰 해드리겠습니다! 자료는 기존 자료를 복제하는 대신 새로운 내용을 담고 있어야 합니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
시작하는 데 도움이 되는 Hugging Face와 community 자료 목록(🌎로 표시됨) 입니다. 여기에 포함될 자료를 제출하고 싶으시다면 PR(Pull Request)를 열어주세요. 리뷰 해드리겠습니다! 자료는 기존 자료를 복제하는 대신 새로운 내용을 담고 있어야 합니다.
초심자에게 도움이 될 Hugging Face와 커뮤니티 자료 목록(🌎로 표시됨) 입니다. 이곳에 포함될 자료를 제출하고 싶으시다면 PR(Pull Request)를 열어주세요. 리뷰 해드리겠습니다! 자료는 기존 자료를 복제하는 대신 새로운 내용을 담고 있어야 합니다.

chhaewxn
chhaewxn reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@chhaewxn chhaewxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전반적으로 깔끔하게 번역을 잘해주셔서 많이 배울 수 있었습니다 😊😊 자연스럽게 다듬을 수 있는 몇 가지 포인트와 오타 부분만 수정 제안드려요!

docs/source/ko/model_doc/time_series_transformer.md Outdated Show resolved Hide resolved
docs/source/ko/model_doc/time_series_transformer.md Outdated Show resolved Hide resolved
docs/source/ko/model_doc/time_series_transformer.md Outdated Show resolved Hide resolved
jun048098
jun048098 reviewed Oct 4, 2024
View reviewed changes
docs/source/ko/model_doc/time_series_transformer.md Outdated

## Usage tips[[usage-tips]]

- 다은 라이브러리의 모델들과 마찬가지로, [`TimeSeriesTransformerModel`]은 상단에 헤드가 없는 기본적인 트랜스포머 입니다. [`TimeSeriesTransformerForPrediction`]은 상단에 분포 헤드를 추가하여 시계열 예측에 사용할 수 있습니다. 이 모델은 이른바 확률적 예측 모델이며, 포인트 예측 모델이 아닙니다. 즉 샘플링할 수 있는 분포를 학습하며, 값을 직접 출력 하지는 않습니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 다은 라이브러리의 모델들과 마찬가지로, [`TimeSeriesTransformerModel`]은 상단에 헤드가 없는 기본적인 트랜스포머 입니다. [`TimeSeriesTransformerForPrediction`]은 상단에 분포 헤드를 추가하여 시계열 예측에 사용할 수 있습니다. 이 모델은 이른바 확률적 예측 모델이며, 포인트 예측 모델이 아닙니다. 즉 샘플링할 수 있는 분포를 학습하며, 값을 직접 출력 하지는 않습니다.
- 다은 라이브러리의 모델들과 마찬가지로, [`TimeSeriesTransformerModel`]은 상단에 헤드가 없는 기본적인 트랜스포머입니다. [`TimeSeriesTransformerForPrediction`]은 상단에 분포 헤드를 추가하여 시계열 예측에 사용할 수 있습니다. 이 모델은 이른바 확률적 예측 모델이며, 포인트 예측 모델이 아닙니다. 즉 샘플링할 수 있는 분포를 학습하며, 값을 직접 출력 하지는 않습니다.

jun048098
jun048098 reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@jun048098 jun048098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: docs suggestions

@fabxoe fabxoe marked this pull request as ready for review October 7, 2024 02:29
@fabxoe @chhaewxn @ahnjj
fix: resolve suggestions
6e88aed 
Co-authored-by: Chaewon Song <[email protected]>
Co-authored-by: Ahnjj_DEV <[email protected]>
fabxoe
fabxoe commented Oct 7, 2024
View reviewed changes
Copy link
Contributor Author

@fabxoe fabxoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: resolve suggestions

docs/source/ko/model_doc/time_series_transformer.md Outdated Show resolved Hide resolved
docs/source/ko/model_doc/time_series_transformer.md Outdated Show resolved Hide resolved
fabxoe
fabxoe commented Oct 7, 2024
View reviewed changes
Copy link
Contributor Author

@fabxoe fabxoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: resolve suggestions

fabxoe
fabxoe commented Oct 7, 2024
View reviewed changes
Copy link
Contributor Author

@fabxoe fabxoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: resolve suggestions

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

stevhliu
stevhliu approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much, just need to resolve the merge conflict! 🤗

@stevhliu stevhliu merged commit 04f51c4 into huggingface:main Oct 9, 2024
8 checks passed
NielsRogge pushed a commit to NielsRogge/transformers that referenced this pull request Oct 21, 2024
@fabxoe @chhaewxn
@ahnjj @NielsRogge
🌐 [i18n-KO] Translated model_doc/time_series_transformer.md to Kore…
075572b 
…an (huggingface#33596)

* docs: ko: model_doc/time_series_transformer.md

* fix: resolve suggestions

Co-authored-by: Chaewon Song <[email protected]>
Co-authored-by: Ahnjj_DEV <[email protected]>

* fix: resolve suggestions

* fix: resolve suggestions

* fix: resolve suggestions

Co-authored-by: Ahnjj_DEV <[email protected]>

---------

Co-authored-by: Chaewon Song <[email protected]>
Co-authored-by: Ahnjj_DEV <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chhaewxn chhaewxn chhaewxn left review comments

@jun048098 jun048098 jun048098 left review comments

@ahnjj ahnjj ahnjj requested changes

@stevhliu stevhliu stevhliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fabxoe @HuggingFaceDocBuilderDev @ahnjj @stevhliu @jun048098 @chhaewxn