rag: fix CI #33578
Merged
rag: fix CI #33578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gante
commented
Sep 18, 2024
| @@ -653,7 +653,7 @@ class RagDPRT5Test(RagTestMixin, unittest.TestCase): | |||
| def config_and_inputs(self): | |||
| question_encoder_tester = DPRModelTester(self) | |||
| dpr_config_and_inputs = question_encoder_tester.prepare_config_and_inputs() | |||
| generator_tester = T5ModelTester(self, vocab_size=1100) | |||
| generator_tester = T5ModelTester(self, vocab_size=1101) | |||
There was a problem hiding this comment.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Giving a quick approval as @LysandreJik is in SF. Thanks for fixing so quickly!
itazap
pushed a commit
to NielsRogge/transformers
that referenced
this pull request
Sep 20, 2024
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes failing CI on
rag, since #32564.From diving into the error, #32564 did not cause the error, but rather the bug it fixes probably exposed this existing configuration issue.