Fix some missing tests in circleci #33559
Merged
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Sep 18, 2024
ydshieh
commented
Sep 18, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Comment on lines
+315
to
+321
| non_model_job = CircleCIJob( | ||
| "non_model", | ||
| docker_image=[{"image": "huggingface/transformers-torch-light"}], | ||
| marker="not generate", | ||
| parallelism=6, | ||
| pytest_num_workers=8, | ||
| ) |
| @@ -1148,6 +1148,7 @@ def parse_commit_message(commit_message: str) -> Dict[str, bool]: | |||
| "pipelines_torch": r"tests/models/.*/test_modeling_(?!(?:flax_|tf_)).*", | |||
| "tests_hub": r"tests/.*", | |||
| "tests_onnx": r"tests/models/.*/test_modeling_(?:tf_|(?!flax)).*", | |||
| "tests_non_model": r"tests/[^/]*?/test_.*\.py", | |||
There was a problem hiding this comment.
we should make sure we filter to not pass in the test_modeling_llama only test_modeling_utils wdyt?
There was a problem hiding this comment.
It's already the case:
This re r"tests/[^/]*?/test_.*\.py" won't include test_modeling_llama (which is inside tests/models), because it excludes the 2nd/ using [^/]
There was a problem hiding this comment.
ahh okay all good for me then!
ydshieh
force-pushed
the
fix_missing_circleci
branch
from
0dc6063
to
cd0e800
Compare
|
Hi @gante ! The PR #33219 has a change which cause config_dict = model_config.to_dict()
# generation config (which in turn is defined from the outer attributes of model config).
> decoder_config = model_config.get_text_config(decoder=True)
E AttributeError: 'GenerationConfig' object has no attribute 'get_text_config'
src/transformers/generation/configuration_utils.py:1240: AttributeError
================================================================================ short test summary info =================================================================================FAILED tests/generation/test_configuration_utils.py::GenerationConfigTest::test_initialize_new_kwargs - AttributeError: 'GenerationConfig' object has no attribute 'get_text_config' Could you take a look 🙏 ? |
|
Somehow a bit strange |
ydshieh
force-pushed
the
fix_missing_circleci
branch
from
cd0e800
to
4e52906
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Run tests in
tests/generationetc. in a new job