Enable padding_side as call time kwargs
#33385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
The failing test is not related to this PR, seems to be related to training datasets and tasks. PR is ready for review! |
amyeroberts
approved these changes
Sep 10, 2024
|
Looks good to me thanks @zucchini-nlp, this should unblock a lot of the kwargs uniformization PRs :). Anything blocking before this gets merged? Is it because of the tests failing? |
|
I wanted to get @ArthurZucker 's review as well as this is tokenizers related. For tests I can rerun them and hope they won't fail this time |
ArthurZucker
approved these changes
Sep 13, 2024
|
Thanks, can someone merge pls as the tests won't pass after rerunning? |
|
@zucchini-nlp Yep - I can merge |
itazap
pushed a commit
to NielsRogge/transformers
that referenced
this pull request
Sep 20, 2024
* fix * add padding-side kwarg * add padding side in all models & fix tests * fix copies * fix tests
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Oct 2, 2024
* fix * add padding-side kwarg * add padding side in all models & fix tests * fix copies * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds
padding_sideas a valid kwargs when calling tokenizers, so that the users can set padding side when tokenizing. Is a follow-up from #32858 (comment), where we found that most processors acceptpadding_sidebut don't use it when tokenizing.Added test for that and ran it for all models