-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: avoid human error, automatically infer generative models #33212
Draft
gante
wants to merge
12
commits into
huggingface:main
Choose a base branch
from
gante:run_all_generate_tests_all_times
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
gante
changed the title
CI: automatically infer generative models
CI: avoid human error, automatically infer generative models
Aug 30, 2024
Super cool! If VLMs start failing on generation tests, that's okay. I have a local draft for that, which needs to be reviewed after a few other PRs are merged |
gante
force-pushed
the
run_all_generate_tests_all_times
branch
from
September 20, 2024 16:45
489a2d6
to
1e8e794
Compare
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR:
generate
with an automatic definition -- ifmodel_class.can_generate()
, then it runs tests fromGenerationTesterMixin
. No more human mistakes, which happened frequently in the past months 🐛 🔫all_generative_model_classes
and explain why certain classes are being skipped. (bad apples detected withpy.test tests/models/ -k test_greedy_generate -vv
) 💔generate
from the generic test mixin toGenerationTesterMixin
. This means a) we can have a better overview of what's being tested withgenerate
; and b) model architectures without generative capabilities will have fewer skips 🎯In a follow-up PR:
We need to manually define the model's main input name (e.g.,Done ✅pixel_values
) in the model tester. Make it usemodel.main_input_name
instead, to avoid human errorgenerate
tests will only run ifGenerationTesterMixin
is inherited. We can easily forget to add the mixin, resulting in a false positive. Add an automated check: if any of the model classes can generate, thenGenerationTesterMixin
must be inherited in the tester