Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate docs into Arabic issue-number #32435 #32513

Closed
wants to merge 653 commits into from

Conversation

AhmedAlmaghz
Copy link
Contributor

What does this PR do?

Translate docs into Arabic issue-number #32435
@stevhliu and @MKhalusova

@stevhliu
Copy link
Member

stevhliu commented Aug 7, 2024

Hi!

It is extremely difficult to review 400+ file changes. For translations, you should work on translating one file at a time, get it reviewed by a native Arabic speaker, and then move on to the next document. Translations should also be done manually to ensure nothing gets lost in translation, which can sometimes happen when using machine translation programs/apps.

I noticed you opened similar PRs in the Diffusers/Datasets repositories. The same comment here applies to those PRs as well.

I'd suggest closing these PRs and then opening just one PR focused on translating one document. Thanks! 🤗

@AhmedAlmaghz
Copy link
Contributor Author

AhmedAlmaghz commented Aug 8, 2024

I have been working on the translation for more than two months and I manually translate each file and now that I have finished I have uploaded the translation to you.
HFDocs

@stevhliu

@amyeroberts
Copy link
Collaborator

Hi @AhmedAlmaghz, thank you for dedicating so much time in translating the docs!

It's simply just not feasible for someone to review a PR of this size. For context, the general rule for PRs is that there shouldn't be more than 400 lines of diff for the reviewer. Here there's 61k. You should be able to separate out the file commits into their own PRs, which can then be reviewed.

@abodacs
Copy link
Contributor

abodacs commented Aug 8, 2024

@AhmedAlmaghz
Thanks for the great work.

I will be happy to review small PRs, you did what I procrastinating for a long time.
You can cherry-pick commit/s into separate branches, open a PR, and mention me for reviewing.

Thank you again for the hard work and great addition to the Arabic community (جزاء الله خيرأ)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants