Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new zero-shot examples #32483

Open
wants to merge 80 commits into
base: main
Choose a base branch
from

Conversation

SangbumChoi
Copy link
Contributor

What does this PR do?

Fixes #32459

Following two PR should be merged before merging this example!
#31828
#31964

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

EduardoPach and others added 30 commits June 25, 2024 13:54
Copy link
Member

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SangbumChoi, thanks for iterating! Great work!

I left a comment regarding Trainer, also don't know if it deserves a separate PR. Overall looks very good to me, but I didn't do an in-depth view yet (let's wait for loss PR to be merged). For these examples the tests have to be added and information in README (see files in this directory). Also, feel free to add resources to docs of Grounding DINO. Btw, did you try to fine-tune OwlV2?

src/transformers/trainer.py Outdated Show resolved Hide resolved
@SangbumChoi
Copy link
Contributor Author

SangbumChoi commented Aug 9, 2024

@qubvel Sounds good. I can wait until the loss PR get merged.

Btw, did you try to fine-tune OwlV2?

I didn't aware that we can fine-tune OwlV2, let me see while waiting loss PR!

@SangbumChoi SangbumChoi marked this pull request as draft August 11, 2024 10:50
@SangbumChoi SangbumChoi marked this pull request as ready for review September 26, 2024 01:48
@SangbumChoi
Copy link
Contributor Author

Hi @qubvel It is now ready to review this new example. For the CI error it says unauthorized I'm not sure how to handle this so it would be appreciated to let me know how to fix this.

@SangbumChoi
Copy link
Contributor Author

Screenshot 2024-09-27 at 4 36 25 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero-shot finetuning examples
4 participants