-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new zero-shot examples #32483
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: amyeroberts <[email protected]>
Co-authored-by: amyeroberts <[email protected]>
Co-authored-by: amyeroberts <[email protected]>
Co-authored-by: amyeroberts <[email protected]>
Co-authored-by: amyeroberts <[email protected]>
Co-authored-by: amyeroberts <[email protected]>
Co-authored-by: amyeroberts <[email protected]>
Co-authored-by: amyeroberts <[email protected]>
Co-authored-by: amyeroberts <[email protected]>
Co-authored-by: amyeroberts <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SangbumChoi, thanks for iterating! Great work!
I left a comment regarding Trainer, also don't know if it deserves a separate PR. Overall looks very good to me, but I didn't do an in-depth view yet (let's wait for loss PR to be merged). For these examples the tests have to be added and information in README (see files in this directory). Also, feel free to add resources to docs of Grounding DINO. Btw, did you try to fine-tune OwlV2?
@qubvel Sounds good. I can wait until the loss PR get merged.
I didn't aware that we can fine-tune OwlV2, let me see while waiting loss PR! |
…ach/transformers into grounding_examples
Co-authored-by: Sangbum Daniel Choi <[email protected]>
…ach/transformers into grounding_examples
…to grounding_examples
Hi @qubvel It is now ready to review this new example. For the CI error it says |
What does this PR do?
Fixes #32459
Following two PR should be merged before merging this example!
#31828
#31964
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.