Fix Swift 6 concurrency errors #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
force-pushed
the
mattt/swift-6
branch
from
5b1be9e to
c81d184
Compare
mattt
force-pushed
the
mattt/swift-6
branch
from
09ca451 to
b245552
Compare
This comment was marked as outdated.
This comment was marked as outdated.
mattt
force-pushed
the
mattt/swift-6
branch
from
b245552 to
7b65cc3
Compare
pcuenca
approved these changes
Sep 25, 2025
mattt
force-pushed
the
mattt/swift-6
branch
2 times, most recently
from
6171bb5 to
5a00a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Swift 6 compiler warnings by adding
Sendableconformance and@MainActorannotations to resolve new compiler errors that arise when building the package in Swift 6 language mode. Along the way, it fixes an existing data race inPreTrainedTokenizer.