Reduce access level for extensions on imported types #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
force-pushed
the
mattt/extensions-access-level
branch
2 times, most recently
from
c54f3ed to
9d3c86a
Compare
pcuenca
approved these changes
Sep 24, 2025
Extract and consolidate CoreML extensions into separate file
mattt
force-pushed
the
mattt/extensions-access-level
branch
from
9d3c86a to
f4a35f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to minimize the public API surface area of this package and avoid namespace pollution by reducing the access level for extensions on public types (like
StringandArray), insofar as they're being used as helpers.