-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple chat templates per model #134
Merged
pcuenca
merged 9 commits into
huggingface:main
from
DePasqualeOrg:improve-chat-template-parsing
Oct 3, 2024
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
48f9167
Improve chat template parsing
DePasqualeOrg ac91113
Clean up
DePasqualeOrg 852ea26
Improve chat template selection
DePasqualeOrg b916247
Add tests for chat templates
DePasqualeOrg cb47ba4
Update Sources/Tokenizers/Tokenizer.swift
DePasqualeOrg 19a5da7
Improve template selection
DePasqualeOrg de740f8
More elegant solution for chatTemplate argument
DePasqualeOrg 62ccb41
Update Sources/Tokenizers/Tokenizer.swift
DePasqualeOrg c0355dd
Add overload with `chatTemplate` argument of type `String`
DePasqualeOrg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addGenerationPrompt
is false by default in this method (which mirrors the Python implementation), but it is currently set to true in the overload method. Should we make the behavior consistent in allapplyChatTemplate
methods? Should it be true or false by default?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be
true
for the overloads as I expect that to be the most common use of the API, but I'm not fully sure.