[FIX] Invalid None check for loftq_config attribute in LoraConfig
#2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2170
I improved the handling of loftq attributes in the
__init__method ofLoraConfig.Aside from fixing the issue of the None check I added a warning when
init_lora_weights != "loftq"butloftq_configis not specified. In that case I think it also makes sense to resetloftq_configto an empty dict.I added two testcases for the expected Error/Warning is raised.
fyi: on my local machine a lot of gpu tests are failing but I dont think it is related to the changes as the same tests are failing when using the repo state from the main branch.