Skip to content

Refactor metadata reading #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

julien-c
Copy link
Member

Summary

  • factorize metadata reading logic in _local_folder.py

Testing

  • make style
  • make quality (fails: missing type stubs)
  • make test (fails: test collection errors)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@julien-c
Copy link
Member Author

julien-c commented May 23, 2025

just seeing whether it passes the tests. EDIT: ok it does

@julien-c julien-c marked this pull request as ready for review May 23, 2025 15:07
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the code is correct and does what we want, I don't find it more readable (it de-duplicates the try/except/paths.unlink() logic at the cost of one level of abstraction more)

@julien-c
Copy link
Member Author

@copilot close the PR following maintainer feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants