Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ML-Agents and RL-Baselines3-Zoo #207

Merged
merged 28 commits into from
Jun 27, 2022
Merged

Add ML-Agents and RL-Baselines3-Zoo #207

merged 28 commits into from
Jun 27, 2022

Conversation

simoninithomas
Copy link
Member

@simoninithomas simoninithomas commented Jun 23, 2022

Hey there 👋 ,

I've added RL-Baselines3-Zoo and ML-Agents integration to the libraries doc.
I followed the alphabetical order since it's seems to be the classification method.

Edit:

  • I also added ML-Agents directly on Librairies.ts and Tasks (thanks for the tip Omar).

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 23, 2022

The documentation is not available anymore as the PR was closed or merged.

@osanseviero
Copy link
Contributor

Thanks for the PR! Would it be possible to also add some high level guides such as https://github.com/huggingface/hub-docs/blob/main/docs/hub/allennlp.md / https://huggingface.co/docs/hub/allennlp?

@simoninithomas
Copy link
Member Author

Sure no pb! I also added ML-Agents in Librairies and const.ts (tasks). Initially I wanted to make a separate PR but I commit on the same branch.

@osanseviero
Copy link
Contributor

Up to you! I'm ok with separate PRs :) just let us know when it's ready for review by requesting it

@simoninithomas
Copy link
Member Author

The 3 documentations are done 🥳 @osanseviero

  • MLAgents (but one problem with the Gif display 😢 )
  • SB3
  • RL-Zoo

@osanseviero osanseviero self-requested a review June 23, 2022 13:48
@osanseviero
Copy link
Contributor

Fixes #204

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! It's only missing the code snippet for ML Agents

docs/hub/ml-agents.md Outdated Show resolved Hide resolved
docs/hub/ml-agents.md Show resolved Hide resolved
docs/hub/ml-agents.md Show resolved Hide resolved
docs/hub/ml-agents.md Outdated Show resolved Hide resolved
docs/hub/rl-baselines3-zoo.md Outdated Show resolved Hide resolved
docs/hub/rl-baselines3-zoo.md Outdated Show resolved Hide resolved
docs/hub/rl-baselines3-zoo.md Outdated Show resolved Hide resolved
docs/hub/rl-baselines3-zoo.md Outdated Show resolved Hide resolved
docs/hub/stable-baselines3.md Show resolved Hide resolved
js/src/lib/interfaces/Libraries.ts Outdated Show resolved Hide resolved
@simoninithomas
Copy link
Member Author

I updated based on your feedback @osanseviero though I've still have a problem with the gif when I check the MLAgents page. Is it because it's a temporary build?

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for this 🔥

@osanseviero
Copy link
Contributor

@mishig25 do we have support for gifs with docs builder?

@osanseviero
Copy link
Contributor

re-ping @mishig25 on this one :)

@simoninithomas simoninithomas merged commit 669464d into main Jun 27, 2022
@simoninithomas simoninithomas deleted the add_mlagents branch June 27, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants