Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In unit2, in function "push_to_hub", the variable "env_id" has been used for the definition of variable "model_card". This variable, "env_id", hasn't been defined in the function "push_to_hub", and it uses a variable from outside of the function which is not necessarily the right value. It should be replaced with "model["env_id"]", i.e., "env_id" -> "model["env_id"]".
Model card is not updated when a new push is done, so I commented the following lines:
readme = ""
print(readme_path.exists())
if readme_path.exists():
with readme_path.open("r", encoding="utf8") as f:
readme = f.read()
else:
readme = model_card
and added "readme = model_card", so that the model card is updated for each push.