Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Websearch] Fix UI flicker #710

Merged
merged 2 commits into from
Jan 22, 2024
Merged

[Websearch] Fix UI flicker #710

merged 2 commits into from
Jan 22, 2024

Conversation

mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Jan 19, 2024 •
edited
Loading

As noted here, there was a UI big flickering bug when using websearch

Before

trimmedflicker.mov

After

done.mov

@mishig25
Copy link
Collaborator Author

thanks a lot to @mikelfried who provided a solution 6c6e290

@mishig25 mishig25 changed the title [Wbesarch] Fix UI flicker [Webesarch] Fix UI flicker Jan 19, 2024
@mishig25 mishig25 changed the title [Webesarch] Fix UI flicker [Websearch] Fix UI flicker Jan 19, 2024
nsarrazin
nsarrazin approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@nsarrazin nsarrazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, seems to work well

@mishig25 mishig25 merged commit f35e104 into main Jan 22, 2024
3 checks passed
@mishig25 mishig25 deleted the fix/websearch_flicker branch January 22, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsarrazin nsarrazin nsarrazin approved these changes

@gary149 gary149 Awaiting requested review from gary149

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mishig25 @nsarrazin