Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mv embeddingEndpoints.ts #688

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Mv embeddingEndpoints.ts #688

merged 2 commits into from
Jan 10, 2024

Conversation

mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Jan 10, 2024 •
edited
Loading

nsarrazin
nsarrazin approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@nsarrazin nsarrazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes more sense wrt to the way we do inference endpoints, lgtm!

@mishig25 mishig25 merged commit 41f8b74 into main Jan 10, 2024
3 checks passed
@mishig25 mishig25 deleted the mv_embedding_endpoints_file branch January 10, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsarrazin nsarrazin nsarrazin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mishig25 @nsarrazin