feat: add DEFAULT_MAX_TOKENS env variable for global token limit #2069
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a new
DEFAULT_MAX_TOKENSenvironment variable that sets a global default formax_tokensacross all models, eliminating the need to configuremax_tokensindividually for each model in theMODELSenv var.Why
When using OpenAI-compatible backends like NVIDIA NIM, not setting
max_tokenscan cause issues:Input length + max new tokens > max sequence lengthBefore this change, users had to configure both
OPENAI_BASE_URLandMODELSjust to setmax_tokens:OPENAI_BASE_URL=http://nim-service.namespace.svc.cluster.local/v1 MODELS='[{"id":"meta/llama-3.1-8b-instruct","name":"Llama 3.1 8B (NIM)","parameters":{"max_tokens":4096}}]'After this change, users can simply set:
This is much simpler - no need to duplicate the model ID/name or use the
MODELSconfig just for setting token limits.Changes
src/lib/server/config.tsDEFAULT_MAX_TOKENStoExtraConfigKeystypesrc/lib/server/endpoints/openai/endpointOai.tsDEFAULT_MAX_TOKENSas fallback when model'smax_tokensparameter is not setTest plan
npm run checkpassesmax_tokensvaluesparameters.max_tokensstill takes priority overDEFAULT_MAX_TOKENS