Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove right margin from custom scrollbar #1498

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rotemdan
Copy link

Here's a basic pull request for an attempt at fixing #1492

You can use it as a starting point. It's not tested (tried to run npm run preview locally but it failed due to lack of MongoDB, seems like getting this to work isn't trivial for me and it'd take some more time and effort than I have right now).

I simply removed the tailwind class mr-1, which means:

.mr-1 {
  margin-right: .25rem;
}

From instances of custom-scrollbar in these source files:

src/lib/components/chat/ChatWindow.svelte
src/routes/assistants/+page.svelte
src/routes/models/+page.svelte
src/routes/tools/+page.svelte

You'll need to test it yourself to ensure it actually works.

@rotemdan
Copy link
Author

rotemdan commented Sep 28, 2024

I've managed to start it locally using a docker container for the MongoDB instance.

The local instance doesn't fully work (getting errors like Authorization header is correct, but the token seems invalid) but I could paste a large amount of text to the chat input to see how the scrollbars behave.

Based on what I've seen, it seems the change does apply correctly.

Just note that Chromium has an unrelated issue with scrollbars: on my PC, for a zoom level of 125%, the scrollbar isn't pressable at the right edge, but with other zoom levels (100%, 150%, etc.) it does work. I've seen this happen on many other websites. It could be some internal issue with rounding of fractional pixels, or something of that sort. I'm not sure if it's actually reported on the Chromium tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant