[feature] Embed assistants #1489
Open
+281
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishig25
force-pushed
the
embed_assistant
branch
2 times, most recently
from
3194ba5
to
54f1570
Compare
gary149
reviewed
Sep 27, 2024
|
|
||
| document.addEventListener('DOMContentLoaded', function() { | ||
| const button = document.createElement('button'); | ||
| button.className = 'fixed bottom-5 right-5 z-50 px-1.5 py-1 bg-blue-500 text-white rounded cursor-pointer hover:bg-blue-600 transition-colors flex items-center focus:outline-none'; |
There was a problem hiding this comment.
how is it going to work with tailwindcss?
There was a problem hiding this comment.
will convert it back to regular css once we agree on the design
mishig25
force-pushed
the
embed_assistant
branch
7 times, most recently
from
ed116a5
to
8749982
Compare
mishig25
force-pushed
the
embed_assistant
branch
from
b19cc4b
to
fb52674
Compare
mishig25
commented
Sep 28, 2024
Comment on lines
+206
to
+213
| <!-- TODO: remove --> | ||
| {#if !$page.data.embeddedAssistantId} | ||
| <script | ||
| src="http://localhost:5173/chat/api/assistant/{$page.data.assistants.at(-1) | ||
| ._id}/embed-snippet" | ||
| defer | ||
| ></script> | ||
| {/if} |
There was a problem hiding this comment.
to make testing the embedded assistants easier, I'm embedding hf assistant inside the chat-ui. These lines would be removed before merging to main.
you can change {$page.data.assistants.at(-1)._id} this part that grabs the last assistant id to any specific local assistant id if you want
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users can now create tools and connect their tools to their assistants (read here), making for use cases such as: create an assistant that queries your websites and chats about your website.
This PR adds an ability where users can embed their assistants on their websites.
Step1: under assistants settings, there will be
scripttag that can be put on a website's html head section.Step2:
HF Chatbutton will appear on the bottom right section of your website.Step3: When you click on
HF Chatbutton, a chat window modal with minimal hf/hf-chat chrome will appearTesting locally
Reviewing
when reviewing make sure to click
Hide whitespaceto see the actual diffScreen recording
Screen.Recording.2024-09-28.at.11.00.44.mov
it may look bit confusing in the video because I'm embedding hf-chat inside hf-chat locally for testing purposes. but you can imagine the hf-chat modal being embedded on any arbitrary website