-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(embeddingModel): add embedding model into mongodb #1362
base: main
Are you sure you want to change the base?
feat(embeddingModel): add embedding model into mongodb #1362
Conversation
Will the default embedding model setting be inserted in the database every time the server restarts? |
For now - yes, in order to support the current behavior and allow users to edit embedding models via |
Hi @nsarrazin, what do you think about this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the contrib, this looks like a nice feature, will do a deeper review soon but just curious, how do you handle the API keys stored in the env variable? Do you copy these over in the DB?
Hi there, I hope I got the question right. I'm not touching API keys at all, I just parse |
I meant for example the OpenAI embedding endpoint has an |
Oh, good catch, I missed that part. In this case we need to encrypt/decrypt api keys using some encryption key 👍 |
f09dcd0
to
ea01acd
Compare
Hi @nsarrazin, I added an encryption for sensitive data 👍 |
Hi there,
I decided to create the first PR which migrate config management from
.env
file to UI.How do I see it:
EmbeddingModel
Model
EmbeddingModel
andModel
WDYT?
Part of #1286