Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "login" button text wrap on mobile #1315

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Fix "login" button text wrap on mobile #1315

merged 2 commits into from
Jul 1, 2024

Conversation

neven4
Copy link
Contributor

@neven4 neven4 commented Jun 27, 2024

Closes: #1314

@neven4
Copy link
Contributor Author

neven4 commented Jun 27, 2024

Also, I can create a separate LoginButton component, but I'm not sure at what point you decide to extract code into a separate component. Is 2 repetitions enough?

@julien-c
Copy link
Member

wow that was fast 🤯

nsarrazin
nsarrazin approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@nsarrazin nsarrazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contrib! Looks great, will deploy 🚀

@nsarrazin nsarrazin merged commit 04707e4 into huggingface:main Jul 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsarrazin nsarrazin nsarrazin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Sign in with 🤗 Hugging Face" button for login modal can look strange at narrow widths
3 participants
@neven4 @julien-c @nsarrazin