Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sign in with 馃 Hugging Face" button for login modal can look strange at narrow widths #1314

Open
Mardak opened this issue Jun 27, 2024 · 2 comments 路 May be fixed by #1315
Open

"Sign in with 馃 Hugging Face" button for login modal can look strange at narrow widths #1314

Mardak opened this issue Jun 27, 2024 · 2 comments 路 May be fixed by #1315

Comments

@Mardak
Copy link

Mardak commented Jun 27, 2024

Relatively minor issue with left side of this screenshot shows the beginning and end of the button text overflowing:
narrow hugging chat login

The current code happens to have newline/whitespace that could be preserved or somehow shorten the text?

<button
type="submit"
class="flex w-full items-center justify-center whitespace-nowrap rounded-full bg-black px-5 py-2 text-center text-lg font-semibold text-gray-100 transition-colors hover:bg-gray-900"
>
Sign in
{#if envPublic.PUBLIC_APP_NAME === "HuggingChat"}
with <LogoHuggingFaceBorderless classNames="text-xl mr-1 ml-1.5" /> Hugging Face

@julien-c
Copy link
Member

good catch, a PR is welcome!

@Mardak
Copy link
Author

Mardak commented Jun 27, 2024

Specifically for the Firefox chatbot sidebar use case, we might end up enforcing a minimum width of say 420px and avoid this issue for huggingchat that only appears around 350px.

@neven4 neven4 linked a pull request Jun 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants