Compute 4 Byte selector from SolError and SolFunction #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just saw this, reviewing. |
Philogy
reviewed
Nov 6, 2024
crates/ast/src/util.rs
Outdated
Comment on lines
63
to
64
| func: SolFunction, | ||
| err: SolError, |
There was a problem hiding this comment.
Why does this function take both a func and err? It should be either or
crates/ast/src/util.rs
Outdated
| DynSolType::Address => "address", | ||
| DynSolType::Uint(_) => "uint256", | ||
| DynSolType::String => "string", | ||
| _ => panic!("Unsupported type: {:?}", arg.0), |
There was a problem hiding this comment.
You don't support all types. I think Alloy might have a built-in way, try .to_string()
Philogy
reviewed
Nov 12, 2024
crates/ast/src/util.rs
Outdated
| @@ -53,3 +56,34 @@ pub fn u256_as_push(value: U256) -> Opcode { | |||
| _ => unreachable!(), | |||
| } | |||
| } | |||
|
|
|||
| type Selector = (FixedBytes<4>, FixedBytes<4>); | |||
|
Hey @willco-1, thanks for the contribution. Looking great. Before merging in could you do a few more small things:
thanks! |
|
Nice, almost there. Could you get the tests to pass now? |
|
Clippy 🙃 |
|
Also fixed CI so that you should be able to run it yourself, apologize for the small back and forth 😅 |
|
Closes #6 |
|
Merged in, decided to fix the nit myself. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to solve #6. I think that there might be a better way to do this, perhaps. Also, I am sure there will be stylistic things to change here.. so I am opening it as a Draft Pr. Please advise on any notes.