Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the missing $event in ngClick #306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing the missing $event in ngClick #306

wants to merge 1 commit into from
+7,462 −407

Conversation

Chhaya02
Copy link

@Chhaya02 Chhaya02 commented Feb 5, 2018

Fix: The $event was not getting passed when validation submit was interfering the process call.

@coveralls
Copy link

coveralls commented Feb 5, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 91.44% when pulling ddaf372 on Chhaya02:bug_fix/missing_event into c275196 on hueitan:master.

@hueitan
Copy link
Owner

hueitan commented Feb 5, 2018

Awesome! You spot the hidden issue here 💥 Let's figure out what's the problem with CI then we can merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chhaya02 @coveralls @hueitan