Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Layouts and Maps #515

Open
wants to merge 55 commits into
base: master
Choose a base branch
from
Open

Separate Layouts and Maps #515

wants to merge 55 commits into from

Conversation

garakmon
Copy link
Collaborator

@garakmon garakmon commented Feb 2, 2023 •
edited
Loading

Feature-complete. In need of cleanup and testing.

Internally removes Layout related code from the Map class.
Creates a new layout-only edit mode.
Adds ability to modify map groups.

closes #182
closes #477
closes #181
closes #334
closes #548

TODO:

  • Edit history in timeplapse replays both layouts and events in order of edits made
  • Add new map group & map section & layout without map + delete all above + [Feature Request] Allow Porymap to create new gMapGroups if the one specified doesn't exist by default #550 +rename
  • ScriptUtility::setMainTab(int index) consider edit mode
  • reassigning layouts silences "Setting Map" message log
  • toggle view on empty folders in mapList (map sections, groups, layouts)
  • number map sections?
  • fix all scripting API functions
  • rearrange map groups?
  • drop gMapGroup_ prefix requirement for map groups
  • use NewMapPopup::initUi where needed
  • [BUG] switching to "Connections" tab disables map edits permanently
  • Fix loading recent map except it's a layout
  • Rearrange and rename map sections?

@garakmon garakmon marked this pull request as ready for review February 14, 2023 17:17
@garakmon
reorganize some class data
61256d3
@garakmon
add different tabs for map list views
917e61b
@garakmon
move map pixmap item and metatile rendering from Map to Layout
2bc51f1
@garakmon
fix edit commands and ui things to use layout instead of map
90f8218
@garakmon
setLayout to create layout-only edit mode
18eb3ce
@garakmon
use enum class for edit modes
e225393
@garakmon
save progress
1497f42
@garakmon
gray out map icons until map is open
de8b005 
... because the color of the icon does not mean anything until map has been loaded into memory

for example, if the map's layout has changed then it should be marked as modified but
that wouldn't happen if the map is unloaded
@garakmon
ui to change map's assigned layout id
9918159
@garakmon
add areaList model and filtering, scrolling for all trees
e2ff93e
@garakmon
fix change dimensions for layouts
f7f06da
@garakmon
create dynamic map tab icon
72eb8f8
@garakmon
fix layout undo history
f8c7ada
@garakmon
fix new map popup window to allow layout selection
a4fdb0d
@garakmon
update map lists when new maps and layouts are added
a14e70e
@garakmon
add drag-drop reordering for maps in groups
0ec8f4f
@garakmon
allow editing map group names
d6f3bb1
@garakmon
fix crash in model data function
5d98f8e
@garakmon
save changes to layouts
2ea0590
@garakmon
remove redundant mapsceneeventfilter file
ff086a6
@garakmon
no need to manually crop map tab icon
ac83e0f
@garakmon
add placeholder text for mapgroup label
e79b6e2
@garakmon
preserve layout in config
f485ebd
@GriffinRichards GriffinRichards mentioned this pull request Jan 19, 2024
Merged
@GriffinRichards GriffinRichards mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@garakmon