Fix/#347 missing kubernetes pods metric labels#402
Open
notCamelCaseName wants to merge 3 commits intohubblo-org:devfrom
Open
Fix/#347 missing kubernetes pods metric labels#402notCamelCaseName wants to merge 3 commits intohubblo-org:devfrom
notCamelCaseName wants to merge 3 commits intohubblo-org:devfrom
Conversation
Author
|
see #347 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cgroups were sometimes incorrectly parsed which made it fail to correlate withe the pod's name when running with container support (at least that was the case for k3s).
It may be relevant to add a config for that as the name of the cgroup sometimes varies from one kubernetes distro to another.