Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ga): the accelerator resource ip_type field supports IPV6 #6145

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

ruwenqiang123
Copy link
Contributor

What this PR does / why we need it:

The accelerator resource ip_type field supports IPV6.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
$ make testacc TEST="./huaweicloud/services/acceptance/ga" TESTARGS="-run TestAccAccelerator_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/ga -v -run TestAccAccelerator_basic -timeout 360m -parallel 4
=== RUN   TestAccAccelerator_basic
=== PAUSE TestAccAccelerator_basic
=== CONT  TestAccAccelerator_basic
--- PASS: TestAccAccelerator_basic (96.32s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/ga        96.372s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@jinyangyang222
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Jan 6, 2025
@ruwenqiang123
Copy link
Contributor Author

$ make testacc TEST="./huaweicloud/services/acceptance/ga" TESTARGS="-run TestAccAccelerator_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/ga -v -run TestAccAccelerator_basic -timeout 360m -parallel 4
=== RUN   TestAccAccelerator_basic
=== PAUSE TestAccAccelerator_basic
=== CONT  TestAccAccelerator_basic
--- PASS: TestAccAccelerator_basic (96.35s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/ga        96.449s

@dengyali0125
Copy link

LGTM

@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 6, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 60c8ac2 into huaweicloud:master Jan 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants