Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(secmaster): fix secmaster test case #6139

Merged

Conversation

luoping-12345
Copy link
Contributor

@luoping-12345 luoping-12345 commented Jan 3, 2025

What this PR does / why we need it:

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx
fix secmaster test case

Special notes for your reviewer:

Release note:

fix secmaster test case

PR Checklist

  • Tests added/passed.
make testacc TEST="./huaweicloud/services/acceptance/secmaster" TESTARGS="-run TestAccDataSourceSecmasterPlaybookMonitors_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/secmaster -v -run TestAccDataSourceSecmasterPlaybookMonitors_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceSecmasterPlaybookMonitors_basic
=== PAUSE TestAccDataSourceSecmasterPlaybookMonitors_basic
=== CONT  TestAccDataSourceSecmasterPlaybookMonitors_basic
--- PASS: TestAccDataSourceSecmasterPlaybookMonitors_basic (122.99s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/secmaster 123.089s
make testacc TEST="./huaweicloud/services/acceptance/secmaster" TESTARGS="-run TestAccPlaybookEnable_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/secmaster -v -run TestAccPlaybookEnable_basic -timeout 360m -parallel 4
=== RUN   TestAccPlaybookEnable_basic
=== PAUSE TestAccPlaybookEnable_basic
=== CONT  TestAccPlaybookEnable_basic
--- PASS: TestAccPlaybookEnable_basic (97.05s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/secmaster 97.091s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@Alice1319
Copy link

LGTM

@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Jan 6, 2025
@Jason-Zhang9309
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Jason-Zhang9309

/approve

@github-ci-robot github-ci-robot merged commit 3bd2841 into huaweicloud:master Jan 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. LGTM /lgtm size/XS test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants