Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cbh/instance_quota): support instance quota dataSource #6128

Conversation

jinyangyang222
Copy link
Contributor

@jinyangyang222 jinyangyang222 commented Jan 2, 2025

What this PR does / why we need it:

Support instance quota dataSource

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


Support instance quota dataSource

PR Checklist

  • Tests added/passed.
$ make testacc TEST="./huaweicloud/services/acceptance/cbh" TESTARGS="-run TestAccDataSourceInstanceQuota_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cbh -v -run TestAccDataSourceInstanceQuota_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceInstanceQuota_basic
=== PAUSE TestAccDataSourceInstanceQuota_basic
=== CONT  TestAccDataSourceInstanceQuota_basic
--- PASS: TestAccDataSourceInstanceQuota_basic (7.44s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cbh       7.488s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@jinyangyang222 jinyangyang222 force-pushed the feat-cbh/support-instance_quota-dataSource branch from e0fcdb4 to a99b498 Compare January 2, 2025 06:43
@jinyangyang222 jinyangyang222 force-pushed the feat-cbh/support-instance_quota-dataSource branch from a99b498 to f62da86 Compare January 2, 2025 08:01
@jinyangyang222 jinyangyang222 force-pushed the feat-cbh/support-instance_quota-dataSource branch from f62da86 to 2395ac3 Compare January 2, 2025 08:26
@jinyangyang222
Copy link
Contributor Author

make testacc TEST="./huaweicloud/services/acceptance/cbh" TESTARGS="-run TestAccDataSourceInstanceQuota_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cbh -v -run TestAccDataSourceInstanceQuota_basic -timeout 360m -parallel 4
=== RUN TestAccDataSourceInstanceQuota_basic
=== PAUSE TestAccDataSourceInstanceQuota_basic
=== CONT TestAccDataSourceInstanceQuota_basic
--- PASS: TestAccDataSourceInstanceQuota_basic (7.44s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cbh 7.488s

@Lance52259
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Jan 2, 2025
@deer-hang
Copy link
Contributor

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve

@github-ci-robot github-ci-robot merged commit 99f29bf into huaweicloud:master Jan 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants