Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(identitycenter): add datasource permission set provisionings #6125

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

luoping-12345
Copy link
Contributor

@luoping-12345 luoping-12345 commented Jan 2, 2025

What this PR does / why we need it:
add datasource permission set provisioning statuses

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

add datasource permission set provisioning statuses

PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/identitycenter' TESTARGS='-run TestAccDataSourcePermissionSetProvisionings_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/identitycenter -v -run TestAccDataSourcePermissionSetProvisionings_basic-timeout 360m -parallel 4
=== RUN   TestAccDataSourcePermissionSetProvisionings_basic
=== PAUSE TestAccDataSourcePermissionSetProvisionings_basic
=== CONT  TestAccDataSourcePermissionSetProvisionings_basic
--- PASS: TestAccDataSourcePermissionSetProvisionings_basic(23.11s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/identitycenter40.025s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@luoping-12345 luoping-12345 force-pushed the idc_pro_psets branch 3 times, most recently from 3920324 to 40b1d05 Compare January 2, 2025 09:04
@luoping-12345 luoping-12345 changed the title feat(identitycenter): add datasource permission set provisioning statuses feat(identitycenter): add datasource permission set provisionings Jan 2, 2025
@Alice1319
Copy link

LGTM

3 similar comments
@WangLiNaruto
Copy link

LGTM

@yuanxiaojun987
Copy link

LGTM

@WangLiNaruto
Copy link

LGTM

@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Jan 6, 2025
@Jason-Zhang9309
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Jason-Zhang9309

/approve

@github-ci-robot github-ci-robot merged commit ea87ad2 into huaweicloud:master Jan 6, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants