Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cse/kv): add new data source to query configurations #6114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lance52259
Copy link
Contributor

What this PR does / why we need it:
New data source supported for the CSE service that used to query managed engine configurations (KVs).

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. supports new data source.
2. supports corresponding document and acceptance test.

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o cse -f TestAccDataMicroserviceEngineConfigurations_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/cse" -v -coverprofile="./huaweicloud/services/acceptance/cse/cse_coverage.cov" -coverpkg="./huaweicloud/services/cse" -run TestAccDataMicroserviceEngineConfigurations_basic -timeout 360m -parallel 10
=== RUN   TestAccDataMicroserviceEngineConfigurations_basic
=== PAUSE TestAccDataMicroserviceEngineConfigurations_basic
=== CONT  TestAccDataMicroserviceEngineConfigurations_basic
--- PASS: TestAccDataMicroserviceEngineConfigurations_basic (10.14s)
PASS
coverage: 20.9% of statements in ./huaweicloud/services/cse
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cse       10.189s coverage: 20.9% of statements in ./huaweicloud/services/cse
  • Documentation updated.
  • Schema updated.
  • CheckDeleted.

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Lance52259

@Lance52259 Lance52259 force-pushed the br_cse_data_microservice_engine_configuration branch from dd13e96 to 10e1ca3 Compare December 30, 2024 06:19
@Lance52259 Lance52259 force-pushed the br_cse_data_microservice_engine_configuration branch from 10e1ca3 to 7cab62d Compare December 30, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants