Skip to content

Commit

Permalink
HBASE-14421 TestFastFail* are flakey; ADDENDUM 3 Exclude another shou…
Browse files Browse the repository at this point in the history
…ld assert in TestFastFail
  • Loading branch information
saintstack committed Sep 14, 2015
1 parent 99df022 commit 63a2fb5
Showing 1 changed file with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -268,13 +268,12 @@ public Boolean call() throws Exception {
assertEquals("The regionservers that returned true should equal to the"
+ " number of successful threads", numThreadsReturnedTrue,
numSuccessfullThreads.get());
assertTrue(
"There should be atleast one thread that retried instead of failing",
MyPreemptiveFastFailInterceptor.numBraveSouls.get() > 0);

/* 'should' is not worthy of an assert. Disabling because randomly this seems to randomly
* not but true. St.Ack 20151012
*
assertTrue(
"There should be atleast one thread that retried instead of failing",
MyPreemptiveFastFailInterceptor.numBraveSouls.get() > 0);
assertTrue(
"There should be atleast one PreemptiveFastFail exception,"
+ " otherwise, the test makes little sense."
Expand Down

0 comments on commit 63a2fb5

Please sign in to comment.