Fix when push fail the totalPush variable count cannot increase (alib…

…aba#11704)
huangkemingyyds · Jan 31, 2024 · 1b9a22c · 1b9a22c
1 parent 9d473ef
commit 1b9a22c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/naming/src/main/java/com/alibaba/nacos/naming/push/v2/hook/NacosMonitorPushResultHook.java b/naming/src/main/java/com/alibaba/nacos/naming/push/v2/hook/NacosMonitorPushResultHook.java
@@ -44,6 +44,7 @@ public void pushSuccess(PushResult result) {
 
     @Override
     public void pushFailed(PushResult result) {
+        MetricsMonitor.incrementPush();
         MetricsMonitor.incrementFailPush();
         if (isRpc(result.getSubscriber())) {
             NamingTpsMonitor.rpcPushFail(result.getSubscribeClientId(), result.getSubscriber().getIp());

diff --git a/...g/src/test/java/com/alibaba/nacos/naming/push/v2/hook/NacosMonitorPushResultHookTest.java b/...g/src/test/java/com/alibaba/nacos/naming/push/v2/hook/NacosMonitorPushResultHookTest.java
@@ -101,5 +101,6 @@ public void testPushSuccessForNoEmptyPush() {
     public void testPushFailed() {
         new NacosMonitorPushResultHook().pushFailed(pushResult);
         assertEquals(1, MetricsMonitor.getFailedPushMonitor().get());
+        assertEquals(1, MetricsMonitor.getTotalPushMonitor().get());
     }
 }