fix: decode percent-encoded credentials in URL userinfo

httpie/cli/argparser.py

@@ -5,7 +5,7 @@
 import sys
 from argparse import RawDescriptionHelpFormatter
 from textwrap import dedent
-from urllib.parse import urlsplit
+from urllib.parse import urlsplit, unquote
 
 from requests.utils import get_netrc_auth
 
@@ -289,8 +289,8 @@ def _process_auth(self):
         if self.args.auth is None and not auth_type_set:
             if url.username is not None:
                 # Handle http://username:password@hostname/
-                username = url.username
-                password = url.password or ''
+                username = unquote(url.username)
+                password = unquote(url.password) if url.password else ''
                 self.args.auth = AuthCredentials(
                     key=username,
                     value=password,

tests/test_auth.py

@@ -65,6 +65,27 @@ def test_credentials_in_url_auth_flag_has_priority(httpbin_both):
     assert r.json == {'authenticated': True, 'user': 'user'}
 
 
+@pytest.mark.parametrize('url, expected_username, expected_password', [
+    # %40 = @, %3d = =, %3f = ?
+    ('u%40d:1%3d2%[email protected]', 'u@d', '1=2?'),
+    # %3A = :
+    ('user%3Aname:pass%[email protected]', 'user:name', 'pass:word'),
+    # Simple case without encoding
+    ('user:[email protected]', 'user', 'password'),
+])
+def test_percent_encoded_credentials_in_url(url, expected_username, expected_password):
+    """
+    Percent-encoded characters in URL credentials should be decoded.
+
+    https://github.com/httpie/cli/issues/1623
+
+    """
+    args = httpie.cli.definition.parser.parse_args(args=[url], env=MockEnvironment())
+    assert args.auth
+    assert args.auth.username == expected_username
+    assert args.auth.password == expected_password
+
+
 @pytest.mark.parametrize('url', [
     '[email protected]',
     'username:@example.org',