Merge pull request #51 from http4s/blocking-requires-blocking

Blocking servlets require blocking Servlet I/O
http4s · Jun 6, 2022 · 6f5026e · 6f5026e
2 parents 716a20c + ba3d295
commit 6f5026e
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/servlet/src/main/scala/org/http4s/servlet/BlockingHttp4sServlet.scala b/servlet/src/main/scala/org/http4s/servlet/BlockingHttp4sServlet.scala
@@ -26,14 +26,22 @@ import org.http4s.server._
 import javax.servlet.http.HttpServletRequest
 import javax.servlet.http.HttpServletResponse
 
-class BlockingHttp4sServlet[F[_]](
+class BlockingHttp4sServlet[F[_]] private (
     service: HttpApp[F],
     servletIo: ServletIo[F],
     serviceErrorHandler: ServiceErrorHandler[F],
     dispatcher: Dispatcher[F],
 )(implicit F: Sync[F])
     extends Http4sServlet[F](service, servletIo, dispatcher) {
 
+  def this(
+      service: HttpApp[F],
+      servletIo: BlockingServletIo[F],
+      serviceErrorHandler: ServiceErrorHandler[F],
+      dispatcher: Dispatcher[F],
+  )(implicit F: Sync[F]) =
+    this(service, servletIo: ServletIo[F], serviceErrorHandler, dispatcher)(F)
+
   @deprecated("Binary compatibility", "0.23.12")
   private[servlet] def this(
       service: HttpApp[F],