[fix] pass more useful information to the error that we dont already … #957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the caveat here is that this is a breaking change, but i think it provides more useful context to the
error
as theerror
should be the actualproxyReq
and not thereq
itself. In most cases (or at least using thecallback
api, you already have access toreq
andres
so providing these ends up being useless. We were also previously capturing errors from client requests which I believe was creating false positives for people.Thoughts @donasaur @indexzero