Introduce countDigits() function for PID and UID field widths #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explorer09
force-pushed
the
count-digits
branch
from
7d40b68 to
9c9794a
Compare
BenBE
added
enhancement
BenBE
approved these changes
Nov 11, 2024
Explorer09
commented
Nov 13, 2024
The GPU_TIME field is now fixed width, and thus there is no need to call Row_updateFieldWidth(). Signed-off-by: Kang-Che Sung <[email protected]>
countDigits() is designed with 64-bit integer input and may be reused for computing field widths of, for example, memory addresses. Signed-off-by: Kang-Che Sung <[email protected]> Co-authored-by: Benny Baumann <[email protected]> Co-authored-by: Odric Roux-Paris <[email protected]>
Explorer09
force-pushed
the
count-digits
branch
from
9c9794a to
3385022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The countDigits function was proposed in #1270 (@BenBE and @MrCirdo). And I make PID and UID field widths the first users of this new function.