Fix possible memory leak in Settings.c

htop-dev · Jan 4, 2025 · 8990cc5 · 8990cc5
1 parent 1f24250
commit 8990cc5
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/Settings.c b/Settings.c
@@ -650,11 +650,15 @@ int Settings_write(const Settings* this, bool onCrash) {
       xAsprintf(&tmpFilename, "%s.tmp.XXXXXX", this->filename);
       int fdtmp = mkstemp(tmpFilename);
       umask(cur_umask);
-      if (fdtmp == -1)
+      if (fdtmp == -1) {
+         free(tmpFilename);
          return -errno;
+      }
       fp = fdopen(fdtmp, "w");
-      if (!fp)
+      if (!fp) {
+         free(tmpFilename);
          return -errno;
+      }
       separator = '\n';
       of = fprintf;
    }