Skip to content
This repository has been archived by the owner on Aug 6, 2019. It is now read-only.

[indexedDB] Replace setVersion with upgradeneeded #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pikotea
Copy link

@pikotea pikotea commented Feb 12, 2013

Update "A Simple TODO List using IndexedDB"
This commit is related to html5rocks/www.html5rocks.com#283

@pikotea
Copy link
Author

pikotea commented Feb 12, 2013

@adanilo Could you confirm this commit?

@@ -120,7 +115,7 @@ function renderTodo(row) {
a.textContent = " [Delete]";
li.appendChild(t);
li.appendChild(a);
todos.appendChild(li);
todos.appendChild(li)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this.

@agektmr
Copy link
Member

agektmr commented Feb 13, 2013

LGTM except commented line

@pikotea
Copy link
Author

pikotea commented Feb 13, 2013

Thanks you for your review. :)

@agektmr
Copy link
Member

agektmr commented Feb 22, 2013

@paullewis @cwilso Can you pull if it lgty?

@agektmr
Copy link
Member

agektmr commented Jul 4, 2013

@cwilso Can you check this one?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants