This repository has been archived by the owner on Aug 6, 2019. It is now read-only.
[indexedDB] Replace setVersion with upgradeneeded #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adanilo Could you confirm this commit? |
| @@ -120,7 +115,7 @@ function renderTodo(row) { | |||
| a.textContent = " [Delete]"; | |||
| li.appendChild(t); | |||
| li.appendChild(a); | |||
| todos.appendChild(li); | |||
| todos.appendChild(li) | |||
|
LGTM except commented line |
|
Thanks you for your review. :) |
|
@paullewis @cwilso Can you pull if it lgty? |
|
@cwilso Can you check this one? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update "A Simple TODO List using IndexedDB"
This commit is related to html5rocks/www.html5rocks.com#283