Bug with custom color theme #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… informed colors including the custom ones, so even new colors (with a new name) will be considered in the generation of the styles of the components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Calendar components do not apply custom colors in
variables.scssin the$colorsvariable.Issue Number: #183
What is the new behavior?
With the change in the way the styles are created for each possibility of color, all colors are defined for the components.
Does this PR introduce a breaking change?
Other information
The examples in (with
color: 'color-custom'settings):/dev/src/demos/demo-basic.ts/dev/src/demos/demo-range.ts/dev/src/demos/demo-modal-range.ts