Numerical result out of range issue in rescan-scsi-bus.sh #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is for Issue hreinecke#33. In some situation,the lun of scsi device become a long numeric string(big than integer) and we hit "Numerical result out of range" warning while running rescan-scsi-bus.sh,i.e.: OLD: /usr/bin/rescan-scsi-bus.sh: line 132: printf: warning: 12644192649239960158: Numerical result out of range Update the scripts to handle the lun as String for the instances of luns being impacted. Signed-off-by: Shuang Qiu <[email protected]>
|
Looks good, but can you respin against the current HEAD? |
|
Dear @ioriqqe, Please create a PR at official place: Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is for Issue #33.
In some situation,the lun of scsi device become a long numeric string(big than integer)
and we hit "Numerical result out of range" warning while running rescan-scsi-bus.sh,i.e.:
OLD: /usr/bin/rescan-scsi-bus.sh: line 132: printf: warning:
12644192649239960158: Numerical result out of range
Update the scripts to handle the lun as String for the instances of luns being impacted.
Signed-off-by: Shuang Qiu [email protected]